added bogobogosort #1258
Merged
added bogobogosort #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
approved these changes
Oct 2, 2019
sorts/bogo_bogo_sort.py
Outdated
| :return: the list sorted in ascending order | ||
|
|
||
| Examples: | ||
| >>> bogo_bogo_sort([0, 5, 3, 2, 2]) |
There was a problem hiding this comment.
At least one test should have at least one:
- negative integer
- negative float
- zero
- positive integer
- positive float
What happens when we bogo_bogo_sort(list("Hello!")) ?
There was a problem hiding this comment.
Test #2 has negative integer, does that satisfy the requirement?
For bogo_bogo_sort(list("Hello!")) error would be caught has line 53 converts input to integer and would raise ValueError, would you like me to add a try/catch in the algorithm function as well?
There was a problem hiding this comment.
Mixing pos int, pos float, zero, neg int, neg float in a single test was what I was looking for.
Python/machine_learning/dbscan/dbscan.py
Line 14 in 4617aa7
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* added bogobogosort * fix indentation error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Added code for bogobogosort in seperate PR. Thanks for the previous feedback.
Hope this helps!